Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Document limitation using cudf.pandas proxy arrays #16955

Merged

Conversation

Matt711
Copy link
Contributor

@Matt711 Matt711 commented Sep 30, 2024

Description

When instantiating a cudf.pandas proxy array, a DtoH transfer occurs so that the data buffer is set correctly. We do this because functions which utilize NumPy's C API can utilize the data buffer directly instead of going through __array__. This PR documents this limitation.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@Matt711 Matt711 added the doc Documentation label Sep 30, 2024
@Matt711 Matt711 self-assigned this Sep 30, 2024
@Matt711 Matt711 added non-breaking Non-breaking change cudf.pandas Issues specific to cudf.pandas labels Sep 30, 2024
@Matt711 Matt711 requested review from bdice and galipremsagar October 2, 2024 00:19
docs/cudf/source/cudf_pandas/faq.md Outdated Show resolved Hide resolved
docs/cudf/source/cudf_pandas/faq.md Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the cudf.pandas Issues specific to cudf.pandas label Oct 3, 2024
@Matt711 Matt711 changed the title [DOC] Document limitation using cudf.pandas and functions using NumPy's C API [DOC] Document limitation using cudf.pandas proxy arrays Oct 3, 2024
@Matt711 Matt711 requested a review from vyasr October 3, 2024 17:53
docs/cudf/source/cudf_pandas/faq.md Show resolved Hide resolved
docs/cudf/source/cudf_pandas/faq.md Outdated Show resolved Hide resolved
@Matt711 Matt711 requested a review from a team as a code owner October 7, 2024 15:05
@github-actions github-actions bot added the Python Affects Python cuDF API. label Oct 7, 2024
@github-actions github-actions bot removed the Python Affects Python cuDF API. label Oct 7, 2024
@Matt711 Matt711 added the 3 - Ready for Review Ready for review by team label Oct 8, 2024
Copy link
Contributor

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One non-blocking comment. LGTM

@Matt711 Matt711 requested a review from vyasr October 9, 2024 00:48
@Matt711
Copy link
Contributor Author

Matt711 commented Oct 9, 2024

/merge

@rapids-bot rapids-bot bot merged commit bd51a25 into rapidsai:branch-24.12 Oct 9, 2024
88 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team doc Documentation non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants